Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_idna_encoding_query_a with new errno to align to new c-ares version #194

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Update test_idna_encoding_query_a with new errno to align to new c-ares version #194

merged 3 commits into from
Jan 2, 2024

Conversation

kitterma
Copy link
Contributor

@kitterma kitterma commented Jan 2, 2024

See #193

With this change, all tests pass with c-ares 1.24 (but will fail with 1.18).

@kitterma
Copy link
Contributor Author

kitterma commented Jan 2, 2024

It's not expected that the tests would pass with just this change. The vendored c-ares also needs to be updated.

@saghul
Copy link
Owner

saghul commented Jan 2, 2024

The test should check for either, for backwards compatibility.

@kitterma
Copy link
Contributor Author

kitterma commented Jan 2, 2024

The latest commit should do that.

@saghul saghul merged commit b005f58 into saghul:master Jan 2, 2024
20 checks passed
@gjasny gjasny mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitterma @saghul